Thread (33 messages) 33 messages, 5 authors, 2016-06-15

Re: [PATCH v3 07/11] Documentation/replace: tell that -f option bypasses the type check

From: Christian Couder <hidden>
Date: 2016-06-15 22:58:36

From: "Philip Oakley" <redacted>
From: "Christian Couder" <redacted>
quoted
The replaced object and the replacement object must be of the same
type.
-There is no other restriction on them.
+This restriction can be bypassed using `-f`.

Unless `-f` is given, the 'replace' reference must not yet exist.

+There is no other restriction on the replaced and replacement
objects.
Is this trying to allude to the fact that merge commits may be
exchanged with non-merge commits? I strongly believe that this ability
to exchange merge and non-merge commits should be stated _explicitly_
to counteract the false beliefs that are listed out on the internet.
Maybe we can show that in an example. But I think the patch is quite
clear as it is and should be enough.

If we really want to correct some false beliefs, the best would be to
state the truth where those false beliefs are stated.
It's probably better stated in a separate patch for that explicit
purpose to avoid mixed messages within this commit.
If people agree, I will add a another patch with an example in an
EXAMPLE section.

Thanks,
Christian.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help