Re: [PATCH v3 08/11] t6050-replace: check that -f option bypasses the type check
From: Eric Sunshine <hidden>
Date: 2016-06-15 22:58:35
On Sat, Aug 31, 2013 at 3:12 PM, Christian Couder [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Signed-off-by: Christian Couder <redacted> --- t/t6050-replace.sh | 6 ++++++ 1 file changed, 6 insertions(+)diff --git a/t/t6050-replace.sh b/t/t6050-replace.sh index 05be228..0b07a0b 100755 --- a/t/t6050-replace.sh +++ b/t/t6050-replace.sh@@ -276,6 +276,12 @@ test_expect_success 'replaced and replacement objects must be of the same type' grep "$BLOB. points to a replacement object of type .blob" err ' +test_expect_success '-f option bypasses the type check' ' + git replace -f mytag $HASH1 2>err && + git replace -f HEAD^{tree} HEAD~1 2>err && + git replace -f HEAD^ $BLOB 2>err +'
Is there a non-obvious reason you are redirecting stderr to a file in this test? Unlike the test added earlier, this one never consults the error output. By dropping this apparently unnecessary redirection, diagnosis of a regression potentially becomes simpler since any error output from git-replace will become visible when the test is run verbosely.
+
test_expect_success 'replace ref cleanup' '
test -n "$(git replace)" &&
git replace -d $(git replace) &&
--
1.8.4.rc1.31.g530f5ce.dirty