Thread (4 messages) flat view 4 messages, 2 authors, 2016-06-15

Re: [PATCH] Fix compilation on OS X.

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:58:13

Possibly related (same subject, not in this thread)

Torsten Bögershausen [off-list ref] writes:
On 2013-07-20 09.49, Benoit Sigoure wrote:
quoted
+#ifdef __APPLE__
+// On OS X libc headers don't define this symbol.
+extern char **environ;
+#endif
+
A more generic approach could be:

In the file "config.mak.uname": Define a variable in the Darwin section like this
NO_EXT_ENVIRON = UnfortunatelyYes
Actually, it is _wrong_ for us to rely on system header files to
define this symbol for us.  Declaring "extern char **environ" is
responsibility of the user programs (like us).

When _GNU_SOURCE is defined glibc header (I think it is unistd.h)
seem to define it for us.

Perhaps the correct fix is to revert ec535cc2 for everybody, and if
MinGW needs such a workaround, do it inside #ifndef MINGW?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help