Thread (5 messages) flat view 5 messages, 3 authors, 2016-06-15

Re: [PATCH] Fix compilation on OS X.

From: tsuna <hidden>
Date: 2016-06-15 22:58:13

On Sat, Jul 20, 2013 at 12:55 AM, Ramkumar Ramachandra
[off-list ref] wrote:
Benoit Sigoure wrote:
quoted
diff --git a/compat/unsetenv.c b/compat/unsetenv.c
index 4ea1856..addf3dc 100644
--- a/compat/unsetenv.c
+++ b/compat/unsetenv.c
@@ -1,5 +1,10 @@
 #include "../git-compat-util.h"

+#ifdef __APPLE__
+// On OS X libc headers don't define this symbol.
+extern char **environ;
+#endif
+
Shouldn't this go into git-compat-util.h, since there may be other
files depending on this variable?
I thought about that but there are no other files that use `environ'
so I opted for putting it here instead.

-- 
Benoit "tsuna" Sigoure
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help