Re: [PATCH V3 1/4] git-mw: Introduction of GitMediawiki.pm
From: Matthieu Moy <hidden>
Date: 2016-06-15 22:57:46
benoit.person@ensimag.fr writes:
changes from the V2: - Add a way to test, without installation, code that uses GitMediawiki.pm.
This still needs to be documented, even very quickly, somewhere in the code (e.g a comment in the Makefile).
-build install clean: +copy_pm: + cp $(GIT_MEDIAWIKI_PM) $(GIT_ROOT_DIR)/perl/blib/lib/
I already commented on this: http://thread.gmane.org/gmane.comp.version-control.git/227711/focus=227721 Also, it seems to be only part of the solution. With your change, from contrib/mw-to-git/ and after running only "make", ./git-mw takes the installed version of GitMediawiki.pm in priority ../../bin-wrappers/git takes the installed version of git-mw only (i.e. does not know "git mw" if "make install" hasn't been ran).
perlcritic: - perlcritic -2 *.perl + perlcritic -2 *.perl \ No newline at end of file
Please, avoid these whitespace-only changes. They create noise during review, and more potential conflicts. -- Matthieu Moy http://www-verimag.imag.fr/~moy/