benoit.person@ensimag.fr writes:
changes from the V2:
- Add a way to test, without installation, code that uses GitMediawiki.pm.
This still needs to be documented, even very quickly, somewhere in the
code (e.g a comment in the Makefile).
-build install clean:
+copy_pm:
+ cp $(GIT_MEDIAWIKI_PM) $(GIT_ROOT_DIR)/perl/blib/lib/
I already commented on this:
http://thread.gmane.org/gmane.comp.version-control.git/227711/focus=227721
Also, it seems to be only part of the solution. With your change, from
contrib/mw-to-git/ and after running only "make",
./git-mw takes the installed version of GitMediawiki.pm in priority
../../bin-wrappers/git takes the installed version of git-mw only (i.e.
does not know "git mw" if "make install" hasn't been ran).
perlcritic:
- perlcritic -2 *.perl
+ perlcritic -2 *.perl
\ No newline at end of file
Please, avoid these whitespace-only changes. They create noise during
review, and more potential conflicts.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
On 16 June 2013 22:18, Matthieu Moy [off-list ref] wrote:
benoit.person@ensimag.fr writes:
quoted
changes from the V2:
- Add a way to test, without installation, code that uses GitMediawiki.pm.
This still needs to be documented, even very quickly, somewhere in the
code (e.g a comment in the Makefile).
Well, I think I will have to re-read some docs (and some earlier
reviews) about what to write in commit messages, in the emails, in the
code as comments and in the documentation ... I am just totally lost
right now :/ .
quoted
-build install clean:
+copy_pm:
+ cp $(GIT_MEDIAWIKI_PM) $(GIT_ROOT_DIR)/perl/blib/lib/
I already commented on this:
http://thread.gmane.org/gmane.comp.version-control.git/227711/focus=227721
Oops, I forgot that one, so sorry :/ .
Also, it seems to be only part of the solution. With your change, from
contrib/mw-to-git/ and after running only "make",
./git-mw takes the installed version of GitMediawiki.pm in priority
../../bin-wrappers/git takes the installed version of git-mw only (i.e.
does not know "git mw" if "make install" hasn't been ran).
Same thing as the documentation point, I think I am a bit lost in that
whole thing. I will re-look into it for the next version :/ .
quoted
perlcritic:
- perlcritic -2 *.perl
+ perlcritic -2 *.perl
\ No newline at end of file
Please, avoid these whitespace-only changes. They create noise during
review, and more potential conflicts.
For that one, I don't know why git assumes there is a change in it :
from what I see there is absolutely no whitespaces changes but maybe
my editor added some weird character somewhere ? I will look into that
for the next version ...
Thank you,
Benoit Person