Thread (15 messages) flat view 15 messages, 8 authors, 2016-06-15

Re: [PATCH] gitk: add support for -G'regex' pickaxe variant

From: Jonathan Nieder <hidden>
Date: 2016-06-15 22:57:12

Possibly related (same subject, not in this thread)

Paul Mackerras wrote:
I thought I had replied to this patch; maybe I only thought about it.

Given that we already have a selector to choose between exact and
regexp matching, it seems more natural to use that rather than add a
new selector entry.  Arguably the "IgnCase" option should be disabled
when "adding/removing string" is selected.
Thanks.  I think I disagree: "log -G" and "log -S" are different
operations, not variations on the same one.  

The description "Find next commit adding/removing string:" very
clearly conveys what "-S" means.  Maybe -G would be more clearly
described as "Find next commit changing line that matches regex:" or
"Find next commit changing line containing:"?

Jonathan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help