Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH] gitk: add support for -G'regex' pickaxe variant

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:57:14

Martin Langhoff [off-list ref] writes:
On Mon, May 13, 2013 at 3:33 PM, Jonathan Nieder [off-list ref] wrote:
quoted
Well, no, it should find the final change that brought it into the
current form.  Just like "git blame".

Has it been finding zero results in some cases where the current code
matches the pattern?  That sounds like a bug.
Ummm, maybe. You are right, with current git it does work as I would
expect (usefully ;-) ).

I know I struggled quite a bit with log -S not finding stuff I thought
it should and that log -G did find, back a year ago.

Damn, I don't have a precise record of what git it was on, nor a good
repro example. Too long ago,
Since its beginning, the -S implementation hasn't change that much,
and I do not remember fixing such a bug. If you saw issues in old
Git, the same issues would still exist in today's Git.

It could be that a change to your history (not change to Git) was
introduced in an evil merge, and you were running "git log -p -S"
without "-m", or something.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help