Re: [PATCH 4/4] fast-export: trivial cleanup

On Thu, May 9, 2013 at 4:53 AM, Felipe Contreras
[off-list ref] wrote:
[snip]

quoted

quoted

@@ -562,9 +561,7 @@ static void handle_tags_and_duplicates(struct string_list *extra_refs)
                        break;
                case OBJ_COMMIT:
                        /* create refs pointing to already seen commits */
-                       commit = (struct commit *)object;
-                       printf("reset %s\nfrom :%d\n\n", name,
-                              get_object_mark(&commit->object));
+                       printf("reset %s\nfrom :%d\n\n", name, get_object_mark(object));

FWIW, this line is now too long (exceeds 80 columns).  Good catch on
the casting though.

-John

PS  Sorry for the duplicate Felipe... I still need to get used to
hitting "Reply All". :-)

The guideline is:

 - We try to keep to at most 80 characters per line.

The key word being *try*.

I saw that, but you actively joined the lines, and there was no need
to.  It didn't even require trying to keep it within 80 columns. :-)

-John