Re: [PATCH 3/4] {fast-export,transport-helper}: style cleanups
From: John Szakmeister <hidden>
Date: 2016-06-15 22:57:10
On Wed, May 8, 2013 at 9:16 PM, Felipe Contreras [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Signed-off-by: Felipe Contreras <redacted> --- builtin/fast-export.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-)diff --git a/builtin/fast-export.c b/builtin/fast-export.c index d60d675..8091354 100644 --- a/builtin/fast-export.c +++ b/builtin/fast-export.c@@ -135,7 +135,7 @@ static void export_blob(const unsigned char *sha1)
[snip]
quoted hunk ↗ jump to hunk
@@ -289,13 +289,13 @@ static void handle_commit(struct commit *commit, struct rev_info *rev) parse_commit(commit); author = strstr(commit->buffer, "\nauthor "); if (!author) - die ("Could not find author in commit %s", + die("Could not find author in commit %s", sha1_to_hex(commit->object.sha1));
It looks like your simple replace didn't account for calls with multiple lines. Now the remaining lines don't line up. :-) There's several more places like this in the patch. -John