Re: [PATCH v2 03/11] tests: at-combinations: improve nonsense()

On Wed, May 8, 2013 at 12:55 AM, Junio C Hamano [off-list ref] wrote:

Felipe Contreras [off-list ref] writes:

quoted

In some circumstances 'git log' might fail, but not because the @
parsing failed. For example: 'git rev-parse' might succeed and return a
bad object, and then 'git log' would fail.

The layer we want to test is revision parsing, so let's test that
directly.

Hmph, but

        git rev-parse Makefile

would happily succeed if there happens to be Makefile in the
directory.

Are we expecting that they are always object names?  If that is the
case, perhaps

        git rev-parse --verify "$1"

would express the intention better.

Probably, although the same would fail before this patch.

-- 
Felipe Contreras