Re: [PATCH 2/2] clone: Allow repo using gitfile as a reference
From: Jonathan Nieder <hidden>
Date: 2016-06-15 22:56:43
Aaron Schrab wrote:
quoted hunk ↗ jump to hunk
--- a/builtin/clone.c +++ b/builtin/clone.c@@ -231,12 +231,19 @@ static void strip_trailing_slashes(char *dir) static int add_one_reference(struct string_list_item *item, void *cb_data) { - char *ref_git; + char *ref_git, *repo;
[...]
+ repo = (char *)read_gitfile(mkpath("%s/.git", ref_git));Why not make repo a "const char *" and avoid the cast? The above would seem to make it too tempting to treat the return value from read_gitfile() as a mutable buffer instead of a real_path string that should be copied asap. Hope that helps, Jonathan