Thread (7 messages) flat view 7 messages, 2 authors, 2016-06-15

Re: [PATCH 2/2] clone: Allow repo using gitfile as a reference

From: Aaron Schrab <hidden>
Date: 2016-06-15 22:56:43

At 16:51 -0700 07 Apr 2013, Jonathan Nieder [off-list ref] wrote:
quoted
-	char *ref_git;
+	char *ref_git, *repo;
[...]
quoted
+	repo = (char *)read_gitfile(mkpath("%s/.git", ref_git));
Why not make repo a "const char *" and avoid the cast?  The above
would seem to make it too tempting to treat the return value from
read_gitfile() as a mutable buffer instead of a real_path string that
should be copied asap.
Good catch.  I'll fix that in the next version.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help