Thread (5 messages) 5 messages, 3 authors, 2016-06-15

Re: [PATCH] fast-export: Allow pruned-references in mark file

From: Felipe Contreras <hidden>
Date: 2016-06-15 22:56:42

Possibly related (same subject, not in this thread)

On Sat, Apr 6, 2013 at 11:04 AM, Antoine Pelisse [off-list ref] wrote:
fast-export can fail because of some pruned-reference when importing a
mark file.

The problem happens in the following scenario:

    $ git fast-export --export-marks=MARKS master
    (rewrite master)
    $ git prune
    $ git fast-export --import-marks=MARKS master

This might fail if some references have been removed by prune
because some marks will refer to no longer existing commits.
git-fast-export will not need these objects anyway as they were no
longer reachable.

We still need to update last_numid so we don't change the mapping
between marks and objects for remote-helpers.
Unfortunately, the mark file should not be rewritten without lost marks
if no new objects has been exported, as we could lose track of the last
last_numid.
Makes sense to me.

Reviewed-by: Felipe Contreras <redacted>

-- 
Felipe Contreras
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help