Re: [PATCH] fast-export: Allow pruned-references in mark file

On Mon, Nov 26, 2012 at 2:23 PM, Antoine Pelisse [off-list ref] wrote:

On Mon, Nov 26, 2012 at 12:37 PM, Felipe Contreras
[off-list ref] wrote:

quoted

On Mon, Nov 26, 2012 at 5:03 AM, Junio C Hamano [off-list ref] wrote:

quoted

Is this a safe and sane thing to do, and if so why?  Could you
describe that in the log message here?

Why would fast-export try to export something that was pruned? Doesn't
that mean it wasn't reachable?

Hello Junio,
Hello Felipe,

Actually the issue happened while using Felipe's branch with his
git-remote-hg.  Everything was going fine until I (or did it run
automatically, I dont remember) ran git gc that pruned unreachable
objects. Of course some of the branch I had pushed to the hg remote
had been changed (most likely rebased).  References no longer exists
in the repository (cleaned by gc), but the reference still exists in
mark file, as it was exported earlier.  Thus the failure when git
fast-export reads the mark file.

Ah, I see, so these objects are _before_ fast-export tries to do
anything, it's just importing the marks without any knowledge if these
objects are going to be used in the export or not.

If that's the case, I don't think it should throw a warning even just skip them.

Then, in the actual export if some of these objects are referenced the
export would fail anyway (but they won't).

Cheers.

-- 
Felipe Contreras