Re: [PATCH v2 0/4] remote-helpers: trivial test fixes

On Sat, Apr 6, 2013 at 11:45 AM, Torsten Bögershausen [off-list ref] wrote:

On 06.04.13 19:29, Felipe Contreras wrote:

quoted

On Sat, Apr 6, 2013 at 11:03 AM, Torsten Bögershausen [off-list ref] wrote:

quoted

quoted

--- a/contrib/remote-helpers/test-hg.sh
+++ b/contrib/remote-helpers/test-hg.sh

@@ -115,7 +115,7 @@ test_expect_success 'update bookmark' '
   git push
   ) &&

-  hg -R hgrepo bookmarks | grep "devel\s\+3:"
+  hg -R hgrepo bookmarks | egrep "devel[[:space:]]+3:"
 '

I would rather use [ \t] instead.

That doesn't work on e.g. Mac OS.
[:space:] is actually portable

Why wouldn't it work? This is from their manpage:

A bracket expression is a list of characters enclosed by [ and ].  It
matches any single character in
that list; if the first character of the list is the caret ^ then it
matches any character not in the
list.  For example, the regular expression [0123456789] matches any
single digit.

-- 
Felipe Contreras