From: Felipe Contreras <hidden> Date: 2016-06-15 22:56:40
Hi,
A reroll, now we do some checks, just avoid test-lint-duplicates, and fix the
outsanding shell portability issue. The rest is the same.
Felipe Contreras (4):
remote-bzr: avoid echo -n
remote-helpers: fix the run of all tests
remote-bzr: remove stale check code for tests
remote-hg: fix hg-git test-case
contrib/remote-helpers/Makefile | 1 +
contrib/remote-helpers/test-bzr.sh | 16 +---------------
contrib/remote-helpers/test-hg-hg-git.sh | 1 -
3 files changed, 2 insertions(+), 16 deletions(-)
--
1.8.2
From: Felipe Contreras <hidden> Date: 2016-06-15 22:56:40
We don't need to check for duplicate test numbers, we don't have them,
and either way test-lint-duplicates doesn't work in this situation.
Also, while we are on it, enable test-lint-shell-syntax to check for sh
errors.
Signed-off-by: Felipe Contreras <redacted>
---
contrib/remote-helpers/Makefile | 1 +
1 file changed, 1 insertion(+)
From: Felipe Contreras <hidden> Date: 2016-06-15 22:56:40
The fastimport plugin was only required in the early stage of
development.
Signed-off-by: Felipe Contreras <redacted>
---
contrib/remote-helpers/test-bzr.sh | 14 --------------
1 file changed, 14 deletions(-)
From: Felipe Contreras <hidden> Date: 2016-06-15 22:56:40
There was some lingering code that shouldn't have been there in the
first place.
Signed-off-by: Felipe Contreras <redacted>
---
contrib/remote-helpers/test-hg-hg-git.sh | 1 -
1 file changed, 1 deletion(-)
Hi,
A reroll, now we do some checks, just avoid test-lint-duplicates, and fix the
outsanding shell portability issue. The rest is the same.
Felipe Contreras (4):
remote-bzr: avoid echo -n
remote-helpers: fix the run of all tests
remote-bzr: remove stale check code for tests
remote-hg: fix hg-git test-case
contrib/remote-helpers/Makefile | 1 +
contrib/remote-helpers/test-bzr.sh | 16 +---------------
contrib/remote-helpers/test-hg-hg-git.sh | 1 -
3 files changed, 2 insertions(+), 16 deletions(-)
Sorry being late, now I installed bzr and hg on one of my machines
One defect found: "\s" is not portable on all grep versions
A "*" is not a "basic regular expression", so we need to use egrep
Sorry for confusion:
A "*" is a basic regular expression, but not the "+"
"+" is an extended regular expression, which is understood
by some grep versions (gnu ?).
Felipe: Should I send a patch, or wait for a re-roll?
Hi,
A reroll, now we do some checks, just avoid test-lint-duplicates, and fix the
outsanding shell portability issue. The rest is the same.
Felipe Contreras (4):
remote-bzr: avoid echo -n
remote-helpers: fix the run of all tests
remote-bzr: remove stale check code for tests
remote-hg: fix hg-git test-case
contrib/remote-helpers/Makefile | 1 +
contrib/remote-helpers/test-bzr.sh | 16 +---------------
contrib/remote-helpers/test-hg-hg-git.sh | 1 -
3 files changed, 2 insertions(+), 16 deletions(-)
Sorry being late, now I installed bzr and hg on one of my machines
One defect found: "\s" is not portable on all grep versions
A "*" is not a "basic regular expression", so we need to use egrep
@@ -21,7 +21,7 @@ if ! "$PYTHON_PATH" -c 'import mercurial'; thenfiif!"$PYTHON_PATH"-c'import hggit';then-skip_all='skipping remote-hg tests; hg-git not available'+skip_all='skipping remote-hg tests; python hggit not available'test_donefi
(And as a micro-nit: the indenting deserves some better indentation:
TAB could be used for *.sh, and sub-shells could be indentented one TAB:
test_expect_success 'update bookmark' '
test_when_finished "rm -rf gitrepo*" &&
(
cd hgrepo &&
hg bookmark devel
/Torsten
On Sat, Apr 6, 2013 at 11:03 AM, Torsten Bögershausen [off-list ref] wrote:
quoted
On 04.04.13 17:36, Felipe Contreras wrote:
quoted
Hi,
A reroll, now we do some checks, just avoid test-lint-duplicates, and fix the
outsanding shell portability issue. The rest is the same.
Felipe Contreras (4):
remote-bzr: avoid echo -n
remote-helpers: fix the run of all tests
remote-bzr: remove stale check code for tests
remote-hg: fix hg-git test-case
contrib/remote-helpers/Makefile | 1 +
contrib/remote-helpers/test-bzr.sh | 16 +---------------
contrib/remote-helpers/test-hg-hg-git.sh | 1 -
3 files changed, 2 insertions(+), 16 deletions(-)
Sorry being late, now I installed bzr and hg on one of my machines
One defect found: "\s" is not portable on all grep versions
A "*" is not a "basic regular expression", so we need to use egrep
That doesn't work on e.g. Mac OS.
[:space:] is actually portable
Why wouldn't it work? This is from their manpage:
A bracket expression is a list of characters enclosed by [ and ]. It
matches any single character in
that list; if the first character of the list is the caret ^ then it
matches any character not in the
list. For example, the regular expression [0123456789] matches any
single digit.
--
Felipe Contreras
From: Felipe Contreras <hidden> Date: 2016-06-15 22:56:42
On Sat, Apr 6, 2013 at 11:03 AM, Torsten Bögershausen [off-list ref] wrote:
quoted hunk
On 04.04.13 17:36, Felipe Contreras wrote:
quoted
Hi,
A reroll, now we do some checks, just avoid test-lint-duplicates, and fix the
outsanding shell portability issue. The rest is the same.
Felipe Contreras (4):
remote-bzr: avoid echo -n
remote-helpers: fix the run of all tests
remote-bzr: remove stale check code for tests
remote-hg: fix hg-git test-case
contrib/remote-helpers/Makefile | 1 +
contrib/remote-helpers/test-bzr.sh | 16 +---------------
contrib/remote-helpers/test-hg-hg-git.sh | 1 -
3 files changed, 2 insertions(+), 16 deletions(-)
Sorry being late, now I installed bzr and hg on one of my machines
One defect found: "\s" is not portable on all grep versions
A "*" is not a "basic regular expression", so we need to use egrep
@@ -21,7 +21,7 @@ if ! "$PYTHON_PATH" -c 'import mercurial'; thenfiif!"$PYTHON_PATH"-c'import hggit';then-skip_all='skipping remote-hg tests; hg-git not available'+skip_all='skipping remote-hg tests; python hggit not available'
Same. Google for 'python hggit' and the result is hg-git; and that's
what you would actually tell your package manager to install.
Cheers.
--
Felipe Contreras
That doesn't work on e.g. Mac OS.
[:space:] is actually portable
Why wouldn't it work? This is from their manpage:
A bracket expression is a list of characters enclosed by [ and ]. It
matches any single character in
that list; if the first character of the list is the caret ^ then it
matches any character not in the
list. For example, the regular expression [0123456789] matches any
single digit.
It's not about the "bracket list".
It's about using \t as an abreviation for TAB.
The "backslash n" as an replacement for TAB is quite often understood by many programs.
It is not demanded to be understood by all grep implementations, please see below.
Instead of using \t you can use a literal TAB.
Contact your local editor how to put that inte source code ;-)
http://pubs.opengroup.org/onlinepubs/009695399/basedefs/xbd_chap09.html#tag_09_03
9.3.2 BRE Ordinary Characters
An ordinary character is a BRE that matches itself: any character in the supported character set, except for the BRE special characters listed in BRE Special Characters.
The interpretation of an ordinary character preceded by a backslash ( '\' ) is undefined, except for:
The characters ')', '(', '{', and '}'
The digits 1 to 9 inclusive (see BREs Matching Multiple Characters)
A character inside a bracket expression