Thread (5 messages) flat view 5 messages, 3 authors, 2016-06-15

Re: [PATCH 1/2] diffcore-pickaxe: respect --no-textconv

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:56:41

Possibly related (same subject, not in this thread)

Jeff King [off-list ref] writes:
I'm OK with this as-is, but I would also be happy to see the re-ordering
and extra cleanup I mentioned elsewhere.
Yeah, I agree that the order is the other way around.  2/2 could be
retitled to say that fill_one() no longer needs to touch, but swapping
the order with the extra clean-up would be much cleaner.
But either way:

  Acked-by: Jeff King [off-list ref]

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help