Re: [PATCH 1/2] diffcore-pickaxe: respect --no-textconv

On Thu, Apr 04, 2013 at 10:45:25AM -0700, Junio C Hamano wrote:

Simon Ruderich [off-list ref] writes:

quoted

git log -S doesn't respect --no-textconv:

    $ echo '*.txt diff=wrong' > .gitattributes
    $ git -c diff.wrong.textconv='xxx' log --no-textconv -Sfoo
    error: cannot run xxx: No such file or directory
    fatal: unable to read files to diff

Reported-by: Matthieu Moy <redacted>
Signed-off-by: Simon Ruderich <redacted>
---

Sounds sensible.

With this change fill_one() no longer needs to update textconv, it
can just take a pointer to one, not a pointer to a pointer to one,
which is [2/2].

Peff, anything I missed?

I'm OK with this as-is, but I would also be happy to see the re-ordering
and extra cleanup I mentioned elsewhere.

But either way:

  Acked-by: Jeff King [off-list ref]

-Peff