Re: [PATCH] count-objects: output "KiB" instead of "kilobytes"

I'm really sorry about that. I'll make sure to run the tests before
sending patches in the future.

On Wed, Apr 3, 2013 at 12:01 AM, Junio C Hamano [off-list ref] wrote:

Mihai Capotă [off-list ref] writes:

quoted

The code uses division by 1024. Also, the manual uses "KiB".

Signed-off-by: Mihai Capotă <redacted>
---
 builtin/count-objects.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/builtin/count-objects.c b/builtin/count-objects.c
index 9afaa88..ecc13b0 100644
--- a/builtin/count-objects.c
+++ b/builtin/count-objects.c

@@ -124,7 +124,7 @@ int cmd_count_objects(int argc, const char **argv, const char *prefix)
              printf("garbage: %lu\n", garbage);
      }
      else
-             printf("%lu objects, %lu kilobytes\n",
+             printf("%lu objects, %lu KiB\n",
                     loose, (unsigned long) (loose_size / 1024));
      return 0;
 }

This breaks existing tests (5301, 7408 and 5700); I noticed it too
late and wasted 20 minutes, having to re-run today's integration
cycle.

Next time, please run the testsuite before sending a patch.