Re: [PATCH] count-objects: output "KiB" instead of "kilobytes"
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:56:37
Possibly related (same subject, not in this thread)
- 2016-06-15 · [PATCH] count-objects: output "KiB" instead of "kilobytes" · Mihai Capotă <hidden>
- 2016-06-15 · Re: [PATCH] count-objects: output "KiB" instead of "kilobytes" · Junio C Hamano <hidden>
Mihai Capotă [off-list ref] writes:
quoted hunk
The code uses division by 1024. Also, the manual uses "KiB". Signed-off-by: Mihai Capotă <redacted> --- builtin/count-objects.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/builtin/count-objects.c b/builtin/count-objects.c index 9afaa88..ecc13b0 100644 --- a/builtin/count-objects.c +++ b/builtin/count-objects.c@@ -124,7 +124,7 @@ int cmd_count_objects(int argc, const char **argv, const char *prefix) printf("garbage: %lu\n", garbage); } else - printf("%lu objects, %lu kilobytes\n", + printf("%lu objects, %lu KiB\n", loose, (unsigned long) (loose_size / 1024)); return 0; }
This breaks existing tests (5301, 7408 and 5700); I noticed it too late and wasted 20 minutes, having to re-run today's integration cycle. Next time, please run the testsuite before sending a patch.