[RFC/PATCH v2 2/8] completion: get rid of empty COMPREPLY assignments
From: Felipe Contreras <hidden>
Date: 2016-06-15 22:55:22
Subsystem:
the rest · Maintainer:
Linus Torvalds
There's no functional reason for those, the only purpose they are supposed to serve is to say "we don't provide any words here", but even for that it's not used consitently. Signed-off-by: Felipe Contreras <redacted> --- contrib/completion/git-completion.bash | 27 --------------------------- 1 file changed, 27 deletions(-)
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index bc0657a..c2fb061 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash@@ -238,7 +238,6 @@ __gitcomp () case "$cur_" in --*=) - COMPREPLY=() ;; *) local IFS=$'\n'
@@ -486,7 +485,6 @@ __git_complete_remote_or_refspec () case "$cmd" in push) no_complete_refspec=1 ;; fetch) - COMPREPLY=() return ;; *) ;;
@@ -502,7 +500,6 @@ __git_complete_remote_or_refspec () return fi if [ $no_complete_refspec = 1 ]; then - COMPREPLY=() return fi [ "$remote" = "." ] && remote=
@@ -776,7 +773,6 @@ _git_am () " return esac - COMPREPLY=() } _git_apply ()
@@ -796,7 +792,6 @@ _git_apply () " return esac - COMPREPLY=() } _git_add ()
@@ -811,7 +806,6 @@ _git_add () " return esac - COMPREPLY=() } _git_archive ()
@@ -856,7 +850,6 @@ _git_bisect () __gitcomp_nl "$(__git_refs)" ;; *) - COMPREPLY=() ;; esac }
@@ -969,7 +962,6 @@ _git_clean () return ;; esac - COMPREPLY=() } _git_clone ()
@@ -993,7 +985,6 @@ _git_clone () return ;; esac - COMPREPLY=() } _git_commit ()
@@ -1027,7 +1018,6 @@ _git_commit () " return esac - COMPREPLY=() } _git_describe ()
@@ -1152,7 +1142,6 @@ _git_fsck () return ;; esac - COMPREPLY=() } _git_gc ()
@@ -1163,7 +1152,6 @@ _git_gc () return ;; esac - COMPREPLY=() } _git_gitk ()
@@ -1240,7 +1228,6 @@ _git_init () return ;; esac - COMPREPLY=() } _git_ls_files ()
@@ -1259,7 +1246,6 @@ _git_ls_files () return ;; esac - COMPREPLY=() } _git_ls_remote ()
@@ -1375,7 +1361,6 @@ _git_mergetool () return ;; esac - COMPREPLY=() } _git_merge_base ()
@@ -1391,7 +1376,6 @@ _git_mv () return ;; esac - COMPREPLY=() } _git_name_rev ()
@@ -1681,7 +1665,6 @@ _git_config () return ;; *.*) - COMPREPLY=() return ;; esac
@@ -2061,7 +2044,6 @@ _git_remote () __gitcomp "$c" ;; *) - COMPREPLY=() ;; esac }
@@ -2105,7 +2087,6 @@ _git_rm () return ;; esac - COMPREPLY=() } _git_shortlog ()
@@ -2174,8 +2155,6 @@ _git_stash () *) if [ -z "$(__git_find_on_cmdline "$save_opts")" ]; then __gitcomp "$subcommands" - else - COMPREPLY=() fi ;; esac
@@ -2188,14 +2167,12 @@ _git_stash () __gitcomp "--index --quiet" ;; show,--*|drop,--*|branch,--*) - COMPREPLY=() ;; show,*|apply,*|drop,*|pop,*|branch,*) __gitcomp_nl "$(git --git-dir="$(__gitdir)" stash list \ | sed -n -e 's/:.*//p')" ;; *) - COMPREPLY=() ;; esac fi
@@ -2312,7 +2289,6 @@ _git_svn () __gitcomp "--revision= --parent" ;; *) - COMPREPLY=() ;; esac fi
@@ -2337,13 +2313,10 @@ _git_tag () case "$prev" in -m|-F) - COMPREPLY=() ;; -*|tag) if [ $f = 1 ]; then __gitcomp_nl "$(__git_tags)" - else - COMPREPLY=() fi ;; *)
--
1.8.0