Thread (9 messages) 9 messages, 1 author, 2016-06-15

[RFC/PATCH v2 0/8] completion: compgen/compadd cleanups

flat view
DORMANTno replies

From: Felipe Contreras <hidden>
Date: 2016-06-15 22:55:22

Revision v2 of 2 in this series.

Revisions (2)
  1. rfc [diff vs current]
  2. v2 current
Hi,

These were hinted by SZEDER, so I went ahead and implemented the changes trying
to keep in mind the new zsh completion werapper. The resulting code should be
more efficient, and a known breakage is fixed.

The first two patches are transplanted from another patch series which most
likely is not going to use them.

I also borrowed the tests from another patch series from SZEDER, but they are
not meant to be applied through this series.

SZEDER implemented some of this, but I prefer my version of the patches.

Felipe Contreras (8):
  completion: trivial test improvement
  completion: get rid of empty COMPREPLY assignments
  completion: add new __gitcompadd helper
  tmp: completion: add SZEDER's tests
  completion: get rid of compgen
  tmp: completion: mark SZEDER's tests as fixed
  completion: get rid of __gitcomp_1
  completion: small optimization

 contrib/completion/git-completion.bash | 77 ++++++++++++----------------------
 t/t9902-completion.sh                  | 66 ++++++++++++++++++++++++++++-
 2 files changed, 91 insertions(+), 52 deletions(-)

-- 
1.8.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help