Re: Re: [PATCH/RFC] test-lib: add support for colors without tput

On Fri, Sep 14, 2012 at 7:28 PM, Johannes Sixt [off-list ref] wrote:

Am 14.09.2012 18:58, schrieb Erik Faye-Lund:

quoted

      tput () {
              case "$1" in
              bold)
-                     echo -ne "\033[1m" ;;
+                     printf "\033[1m" ;;
              setaf)
-                     echo -ne "\033[0;3$2m" ;;
+                     printf "\033[0;3$2m" ;;

This should be
                        printf '\033[0;3%sm' "$2" ;;

Is there a reason for %s rather than %d? It seem it only takes
integers, and with %d at least we'd get an error message if someone
started doing something else...

-- 
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.

You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en