Re: [PATCH/RFC] test-lib: add support for colors without tput

2012/9/14 Erik Faye-Lund [off-list ref]:

On Fri, Sep 14, 2012 at 6:54 PM, Erik Faye-Lund [off-list ref] wrote:

quoted

On Fri, Sep 14, 2012 at 6:41 PM, Erik Faye-Lund [off-list ref] wrote:

quoted

diff --git a/t/test-lib.sh b/t/test-lib.sh
index 78c4286..7d1b34b 100644
--- a/t/test-lib.sh
+++ b/t/test-lib.sh

@@ -129,6 +129,20 @@ export _x05 _x40 _z40 LF
 # This test checks if command xyzzy does the right thing...
 # '
 # . ./test-lib.sh
+

Nice. But this setting should be check that we have a terminal first isn't ?
Some test like this before

test "X$$TERM" != Xdumb \
&&  test -t 1 2>/dev/null  \
&& ....

or the inverse logic. This is what automake  and popt autogen.sh does.

Best Regards