Re: [PATCH v5 15/16] remote-svn: add marks-file regeneration

On Monday 20 August 2012 16:20:27 Junio C Hamano wrote:

Junio C Hamano [off-list ref] writes:

quoted

I think you meant something like:

      init_notes(NULL, notes_ref, NULL, 0);

        marksfile = fopen(marksfilename, "r");
        if (!marksfile) {
              regenerate_marks(marksfilename);
                marksfile = fopen(marksfilename, "r");

Btw, this is FILE* is nowhere closed in your fixuped version in fa/remote-svn.

quoted

                if (!marksfile)

                      die("cannot read marks file!");
      } else {

              ...