Junio C Hamano [off-list ref] writes:
I think you meant something like:
init_notes(NULL, notes_ref, NULL, 0);
marksfile = fopen(marksfilename, "r");
if (!marksfile) {
regenerate_marks(marksfilename);
marksfile = fopen(marksfilename, "r");
if (!marksfile)
die("cannot read marks file!");
} else {
...
Also there is another call to regenerate_marks() without any
argument. Has this even been compile-tested?
I've made regenerate_marks() to take (void) parameter list, as
marksfilename is a file scope static and visible to everybody, and
applied something like the above and queued the result in 'pu'.
On Monday 20 August 2012 16:20:27 Junio C Hamano wrote:
Junio C Hamano [off-list ref] writes:
quoted
I think you meant something like:
init_notes(NULL, notes_ref, NULL, 0);
marksfile = fopen(marksfilename, "r");
if (!marksfile) {
regenerate_marks(marksfilename);
marksfile = fopen(marksfilename, "r");
if (!marksfile)
die("cannot read marks file!");
} else {
...
Also there is another call to regenerate_marks() without any
argument. Has this even been compile-tested?
Yes it compiled and it works (is tested by t9020), but the compiler didn't
complain because I left out void, so every argument was ok. I need to get used
to that C-feature.
I've made regenerate_marks() to take (void) parameter list, as
marksfilename is a file scope static and visible to everybody, and
applied something like the above and queued the result in 'pu'.
That's exactly how I meant it. Thanks for your fixups!
On Monday 20 August 2012 16:20:27 Junio C Hamano wrote:
Junio C Hamano [off-list ref] writes:
quoted
I think you meant something like:
init_notes(NULL, notes_ref, NULL, 0);
marksfile = fopen(marksfilename, "r");
if (!marksfile) {
regenerate_marks(marksfilename);
marksfile = fopen(marksfilename, "r");
Btw, this is FILE* is nowhere closed in your fixuped version in fa/remote-svn.
quoted
if (!marksfile)
die("cannot read marks file!");
} else {
...