Thread (3 messages) flat view 3 messages, 2 authors, 2016-06-15

Re: [PATCH v3 1/2] test: git-stash conflict sets up rerere

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:54:30

Phil Hord [off-list ref] writes:
quoted hunk ↗ jump to hunk
Add a failing test to confirm a conflicted stash apply
invokes rerere to record the conflicts and resolve the
the files it can.

mergetool may be confused by a left-over
state from previous rerere activity causing it to
think no files have conflicts even though they do.
This condition is not verified by this test since a
subsequent commit will change the behavior to enable
rerere for stash conflicts.

Also, the next test expected us to finish up with a reset,
which is impossible to do if we fail (as we must) and it's
an unreasonable expectation anyway.  Begin the next test
with a reset of his own instead.

Signed-off-by: Phil Hord <redacted>
---
 t/t7610-mergetool.sh | 38 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)
diff --git a/t/t7610-mergetool.sh b/t/t7610-mergetool.sh
index f5e16fc..725f316 100755
--- a/t/t7610-mergetool.sh
+++ b/t/t7610-mergetool.sh
...
 test_expect_success 'mergetool takes partial path' '
+    git reset --hard
I'll add " &&" at the end and queue.  Thanks.
     git config rerere.enabled false &&
     git checkout -b test12 branch1 &&
     git submodule update -N &&
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help