Re: [PATCH] Avoid crippled getpass function on Solaris
From: Ben Walton <hidden>
Date: 2016-06-15 22:54:26
Possibly related (same subject, not in this thread)
- 2016-06-15 · Re: [PATCH] Avoid crippled getpass function on Solaris · Jeff King <hidden>
- 2016-06-15 · Re: [PATCH] Avoid crippled getpass function on Solaris · Junio C Hamano <hidden>
- 2016-06-15 · Re: [PATCH] Avoid crippled getpass function on Solaris · Ben Walton <hidden>
- 2016-06-15 · Re: [PATCH] Avoid crippled getpass function on Solaris · Jeff King <hidden>
- 2016-06-15 · Re: [PATCH] Avoid crippled getpass function on Solaris · Ben Walton <hidden>
Excerpts from Jeff King's message of Mon Aug 06 20:35:41 -0400 2012:
quoted hunk ↗ jump to hunk
--- compat/terminal.c | 1 + 1 file changed, 1 insertion(+)diff --git a/compat/terminal.c b/compat/terminal.c index 6d16c8f..bbb038d 100644 --- a/compat/terminal.c +++ b/compat/terminal.c@@ -59,6 +59,7 @@ char *git_terminal_prompt(const char *prompt, int echo) r = strbuf_getline(&buf, fh, '\n'); if (!echo) { + fseek(fh, SEEK_CUR, 0); putc('\n', fh); fflush(fh); }
Acked-by: Ben Walton <redacted> That looks good to me. I'm able to clone a password protected https repository and the prompting works as I'd expect. Thanks -Ben -- Ben Walton Systems Programmer - CHASS University of Toronto C:416.407.5610 | W:416.978.4302