Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH] Avoid crippled getpass function on Solaris

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:54:26

Jeff King [off-list ref] writes:
....  From my reading of
getpassphrase, it does seem to be a drop-in replacement.

So I'm OK conceptually with the patch if we can't do any better. But
getpass still sucks. It doesn't handle echoing, and it may or may not
fall back to reading from stdin if the tty isn't available (which is
disastrous for remote-curl, whose stdin is speaking the remote-helper
protocol to git). So I'd really prefer to make HAVE_DEV_TTY work with
Solaris if we can.
Tay Ray Chuan mentioned in the thread near-by that HAVE_DEV_TTY
codepath worked for him with "FILE *" to fd conversion, I think.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help