Re: [PATCH] Avoid crippled getpass function on Solaris
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:54:25
Possibly related (same subject, not in this thread)
- 2016-06-15 · Re: [PATCH] Avoid crippled getpass function on Solaris · Junio C Hamano <hidden>
- 2016-06-15 · Re: [PATCH] Avoid crippled getpass function on Solaris · Andreas Schwab <hidden>
- 2016-06-15 · Re: [PATCH] Avoid crippled getpass function on Solaris · Jeff King <hidden>
- 2016-06-15 · Re: [PATCH] Avoid crippled getpass function on Solaris · Jeff King <hidden>
- 2016-06-15 · Re: [PATCH] Avoid crippled getpass function on Solaris · Tay Ray Chuan <hidden>
Ben Walton [off-list ref] writes:
quoted hunk
diff --git a/compat/terminal.h b/compat/terminal.h index 97db7cd..8d7b3f9 100644 --- a/compat/terminal.h +++ b/compat/terminal.h@@ -3,4 +3,13 @@ char *git_terminal_prompt(const char *prompt, int echo); +/* getpass() returns at most 8 characters on solaris so use + getpassphrase() which returns up to 256. */ +# if defined (__SVR4) && defined (__sun) /* solaris */ +#define GETPASS getpassphrase +#else +#define GETPASS getpass +#endif + + #endif /* COMPAT_TERMINAL_H */
Wouldn't
#if solaris
#define getpass getpassphrase
#endif
without anything else be more than sufficient?