Re: [PATCH 2/2] difftool: Handle compare() returning -1

David Aguilar [off-list ref] writes:

+sub exit_cleanup
+{
+	my ($tmpdir, $status) = @_;
+	rmtree($tmpdir);
+	if ($status and $!) {
+		my ($package, $file, $line) = caller();
+		warn "$file line $line: $!\n";

Are you sure rmtree() would not clobber $! before the code checks it
here?