Re: [PATCH 2/2] difftool: Handle compare() returning -1

David Aguilar [off-list ref] writes:

+sub exit_cleanup
+{
+	my ($tmpdir, $status) = @_;
+	rmtree($tmpdir);
+	if ($status and $!) {
+		my ($package, $file, $line) = caller();
+		warn "$file line $line: $!\n";

Are you sure rmtree() would not clobber $! before the code checks it
here?

On Thu, Jul 26, 2012 at 12:07 PM, Junio C Hamano [off-list ref] wrote:

David Aguilar [off-list ref] writes:

quoted

+sub exit_cleanup
+{
+     my ($tmpdir, $status) = @_;
+     rmtree($tmpdir);
+     if ($status and $!) {
+             my ($package, $file, $line) = caller();
+             warn "$file line $line: $!\n";

Are you sure rmtree() would not clobber $! before the code checks it
here?

rmtree() calls croak() on fatal error, but it would certainly be
clearer and safer to store $! before calling rmtree.
-- 
David