Thread (49 messages) flat view 49 messages, 4 authors, 2016-06-15

Re: [PATCHv3 04/11] Makefile: apply dependencies consistently to sparse/asm targets

From: Jonathan Nieder <hidden>
Date: 2016-06-15 22:54:09

Jeff King wrote:
                                                     These
flags may sometimes require extra dependencies to be added
(e.g., like GIT-VERSION-FILE; this is not the case for any
of the updated lines in this patch, but it is establishing a
style that will be used in later patches).
[...] 
This patch explicitly does not update the static header
dependencies used when COMPUTED_HEADER_DEPENDENCIES is off.
I think you are asking the commit message to do more work than it
needs to, and to answer questions that no one just trying to
understand the patch would ask. :)

Wouldn't it be simpler to put the ground rules in a comment or a
document somewhere under Documentation/ where they can be easily
found?

Hope that helps,
Jonathan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help