[PATCHv2 1/8] Makefile: apply dependencies consistently to sparse/asm targets
From: Jeff King <hidden>
Date: 2016-06-15 22:54:08
Subsystem:
kernel build + files below scripts/ (unless maintained elsewhere), the rest · Maintainers:
Nathan Chancellor, Nicolas Schier, Linus Torvalds
Possibly related (same subject, not in this thread)
- 2016-06-15 · Re: [PATCHv2 1/8] Makefile: apply dependencies consistently to sparse/asm targets · Junio C Hamano <hidden>
- 2016-06-15 · Re: [PATCHv2 1/8] Makefile: apply dependencies consistently to sparse/asm targets · Thomas Rast <hidden>
- 2016-06-15 · Re: [PATCHv2 1/8] Makefile: apply dependencies consistently to sparse/asm targets · Jeff King <hidden>
- 2016-06-15 · Re: [PATCHv2 1/8] Makefile: apply dependencies consistently to sparse/asm targets · Junio C Hamano <hidden>
When a C file includes a header file or depends on a command-line "-D" macro, we note it in the Makefile like: git.o: common-cmds.h However, other targets built from the C file should also know about this dependency (in particular, .sp and .s files that are not part of the usual build process). We sometimes noted these and sometimes not; let's make sure they are always included. Signed-off-by: Jeff King <redacted> --- Same as v1. Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Makefile b/Makefile
index 62de0b4..537d2ea 100644
--- a/Makefile
+++ b/Makefile@@ -1972,7 +1972,7 @@ shell_compatibility_test: please_set_SHELL_PATH_to_a_more_modern_shell strip: $(PROGRAMS) git$X $(STRIP) $(STRIP_OPTS) $(PROGRAMS) git$X -git.o: common-cmds.h +git.sp git.s git.o: common-cmds.h git.sp git.s git.o: EXTRA_CPPFLAGS = \ '-DGIT_HTML_PATH="$(htmldir_SQ)"' \ '-DGIT_MAN_PATH="$(mandir_SQ)"' \
@@ -1982,9 +1982,9 @@ git$X: git.o GIT-LDFLAGS $(BUILTIN_OBJS) $(GITLIBS) $(QUIET_LINK)$(CC) $(ALL_CFLAGS) -o $@ git.o \ $(BUILTIN_OBJS) $(ALL_LDFLAGS) $(LIBS) -help.sp help.o: common-cmds.h +help.sp help.s help.o: common-cmds.h -builtin/help.sp builtin/help.o: common-cmds.h +builtin/help.sp builtin/help.s builtin/help.o: common-cmds.h builtin/help.sp builtin/help.s builtin/help.o: EXTRA_CPPFLAGS = \ '-DGIT_HTML_PATH="$(htmldir_SQ)"' \ '-DGIT_MAN_PATH="$(mandir_SQ)"' \
--
1.7.11.rc3.5.g201460b