Re: [PATCH] pager: drop "wait for output to run less" hack

On Tue, Jun 05, 2012 at 08:42:14AM -0700, Junio C Hamano wrote:

quoted

I'm really tempted to do this:

Why (I am slower than my usual slow self today, so pardon me)?

Purely to clean up the nasty preexec thing, which is a hack, and should
never be used for new code due to portability issues.

Aren't these already protected with "ifndef WIN32"?

Yes, but it means anything that uses it will not work on Windows.

quoted

I checked, and even RHEL5 is on less 436. So besides people on antique
"I installed less from source more than 5 years ago" systems, my only
concern would be that some other pager depends on this hack in a weird
way. But I have never heard of such a thing, so...

Hrm...

Yeah. This is purely a cleanup thing. It's a cleanup I've wanted to do
for a long time (ever since adding it), but it is not hurting anyone
as-is. We can always just reject new uses of preexec_cb in review (which
is more or less what I'm doing here).

-Peff