Re: [PATCH 2/2] completion: split __git_ps1 into a separate script
From: Felipe Contreras <hidden>
Date: 2016-06-15 22:53:53
On Tue, May 22, 2012 at 11:07 PM, Zbigniew Jędrzejewski-Szmek [off-list ref] wrote:
On 05/22/2012 10:46 PM, Felipe Contreras wrote:quoted
contrib/completion/git-completion.bash | 257 +--------------------------- contrib/completion/git-prompt.sh | 287 ++++++++++++++++++++++++++++++++ t/t9903-bash-prompt.sh | 2 +- 3 files changed, 290 insertions(+), 256 deletions(-) create mode 100644 contrib/completion/git-prompt.sh
since git-prompt is not completion related anymore, should a different directory be used?
That's a good point. I personally wouldn't worry too much about this until there's a real issue. If we were to fix this, I would rather have a 'shell' sub-directory and move everything there; I think have a sub-directory for 'completion' and another for 'prompt' would be overkill. Unfortunately this would mean packagers need to update. Cheers. -- Felipe Contreras