Re: [PATCH 2/2] completion: split __git_ps1 into a separate script

On Wed, May 23, 2012 at 12:29 AM, Ted Pavlic [off-list ref] wrote:

quoted

quoted

 create mode 100644 contrib/completion/git-prompt.sh

Hi,
since git-prompt is not completion related anymore, should a different
directory be used?

Making it even more likely that the __gitdir in one will someday not
match the __gitdir in another...

Which is not a big deal IMO. The "bad" __gitdir() won't get worst than
the current one.

Maybe __gitdir should live inside git-prompt and git-completion would
include git-prompt. That would make everything backward compatible
too. And that way there's a good answer to why git-prompt lives inside
the completion directory.

That's not bad, but still needs people to copy multiple scripts, and
edit. I prefer to have a 'git dir' or something.

-- 
Felipe Contreras