Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15

Re: [PATCH 02/19] tests: add tests for the bash prompt functions in the completion script

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:53:47

Johannes Sixt [off-list ref] writes:
From: Johannes Sixt <redacted>
Subject: [PATCH] fixup! tests: add tests for the bash prompt functions in the
 completion script

- $TRASH_DIRECTORY is /c/dir style path, but git produces c:/dir style
  paths. Use $(pwd), which is short for $(pwd -W) that produces the
  latter, to assemble expected test data and paths read by git.
This comes up very often whenever somebody (including me) touches test
scripts.  We do have a write-up in t/README in "Dos and Don'ts" section,
but apparently that is not sufficient to avoid fix-ups.

Would it be possible to arrange so that $TRASH_DIRECTORY, $TEST_DIRECTORY
and $PWD are set to c:/dir style paths in Windows environment?  What would
we break if we did so?

The other direction of changing the Windows port of git to produce /c/dir
style paths would probably not work, as it would involve ripping out the
path mangling feature of bash in MSYS, which is done for some reason, I
presume.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help