Re: [PATCH 02/19] tests: add tests for the bash prompt functions in the completion script

Johannes Sixt [off-list ref] writes:

From: Johannes Sixt <redacted>
Subject: [PATCH] fixup! tests: add tests for the bash prompt functions in the
 completion script

- $TRASH_DIRECTORY is /c/dir style path, but git produces c:/dir style
  paths. Use $(pwd), which is short for $(pwd -W) that produces the
  latter, to assemble expected test data and paths read by git.

This comes up very often whenever somebody (including me) touches test
scripts.  We do have a write-up in t/README in "Dos and Don'ts" section,
but apparently that is not sufficient to avoid fix-ups.

Would it be possible to arrange so that $TRASH_DIRECTORY, $TEST_DIRECTORY
and $PWD are set to c:/dir style paths in Windows environment?  What would
we break if we did so?

The other direction of changing the Windows port of git to produce /c/dir
style paths would probably not work, as it would involve ripping out the
path mangling feature of bash in MSYS, which is done for some reason, I
presume.

Am 5/9/2012 20:08, schrieb Junio C Hamano:

Would it be possible to arrange so that $TRASH_DIRECTORY, $TEST_DIRECTORY
and $PWD are set to c:/dir style paths in Windows environment?  What would
we break if we did so?

I don't think that this is possible. The POSIX emulation in MSYS (or bash,
dunno) always converts to POSIX style:

bash -c "cd c:/temp; PWD=$(pwd -W); echo $PWD; cd $PWD; pwd; echo $PWD"

c:/temp
/c/temp
/c/temp

That is, even if I use Windows style path to chdir around, the result is
POSIX style.

The other direction of changing the Windows port of git to produce /c/dir
style paths would probably not work, as it would involve ripping out the
path mangling feature of bash in MSYS, which is done for some reason, I
presume.

Doing that is certainly not something that I would be prepared to do just
to make the bash prompt work right ;-) And the added maintainance burden
incurred by the status quo is certainly much cheaper than yet another fork
of MSYS and/or bash.

-- Hannes