Re: [PATCH] completion: simplify __git_complete_revlist_file

On Wed, May 2, 2012 at 1:39 AM, Junio C Hamano [off-list ref] wrote:

Felipe Contreras [off-list ref] writes:

quoted

Use new __gitcomp_nl; this is the last place that uses COMPREPLY and
compgen directly.

Signed-off-by: Felipe Contreras <redacted>
---
 contrib/completion/git-completion.bash |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 31f714d..d877a23 100755

This seems to be based on 'maint', which has 31f714d, but I see two hits
with "git grep 'COMPREPLY.*compgen' contrib/completion" there, so I am not
sure if that is where you wanted it to apply.

The last place that is not the __gitcomp* functions, of course.

I see this was not addressed to me (neither was the other zsh one), so I
take it that the patch is still for discussion, at least for the purpose
of today's integration round.  Ping me when it is ready for either 'pu' or
'next'.

I'd say at least one person should say LGTM before asking you to integrate it.

Cheers.

-- 
Felipe Contreras