Re: [PATCH] completion: simplify __git_complete_revlist_file

Felipe Contreras [off-list ref] writes:

This seems to be based on 'maint', which has 31f714d, but I see two hits
with "git grep 'COMPREPLY.*compgen' contrib/completion" there, so I am not
sure if that is where you wanted it to apply.

I see this was not addressed to me (neither was the other zsh one), so I
take it that the patch is still for discussion, at least for the purpose
of today's integration round.  Ping me when it is ready for either 'pu' or
'next'.

Thanks.

On Wed, May 2, 2012 at 1:39 AM, Junio C Hamano [off-list ref] wrote:

Felipe Contreras [off-list ref] writes:

quoted

Use new __gitcomp_nl; this is the last place that uses COMPREPLY and
compgen directly.

Signed-off-by: Felipe Contreras <redacted>
---
 contrib/completion/git-completion.bash |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 31f714d..d877a23 100755

This seems to be based on 'maint', which has 31f714d, but I see two hits
with "git grep 'COMPREPLY.*compgen' contrib/completion" there, so I am not
sure if that is where you wanted it to apply.

The last place that is not the __gitcomp* functions, of course.

I see this was not addressed to me (neither was the other zsh one), so I
take it that the patch is still for discussion, at least for the purpose
of today's integration round.  Ping me when it is ready for either 'pu' or
'next'.

I'd say at least one person should say LGTM before asking you to integrate it.

Cheers.

-- 
Felipe Contreras

On Wed, May 2, 2012 at 1:46 AM, Felipe Contreras
[off-list ref] wrote:

On Wed, May 2, 2012 at 1:39 AM, Junio C Hamano [off-list ref] wrote:

quoted

I see this was not addressed to me (neither was the other zsh one), so I
take it that the patch is still for discussion, at least for the purpose
of today's integration round.  Ping me when it is ready for either 'pu' or
'next'.

I'd say at least one person should say LGTM before asking you to integrate it.

Nobody has raised any issues with this, so, please merge it to 'pu'.
This is so straight-forward that it might make sense to move to 'next'
through.

Cheers.

-- 
Felipe Contreras

Hi,


On Wed, May 02, 2012 at 01:46:32AM +0200, Felipe Contreras wrote:

On Wed, May 2, 2012 at 1:39 AM, Junio C Hamano [off-list ref] wrote:

quoted

Felipe Contreras [off-list ref] writes:

quoted

Use new __gitcomp_nl; this is the last place that uses COMPREPLY and
compgen directly.

I didn't dare to touch that code back then while doing the
__gitcomp_nl() changes; that sed command looked way too scary ;) But
all it does is to process the output of 'git ls-tree' and removes the
cruft and appends a space to filenames and a '/' to directories
(without a trailing space).  So invoking __gitcomp_nl() with an empty
suffix parameter is OK, as it doesn't change the current behavior.

quoted

quoted

Signed-off-by: Felipe Contreras <redacted>
---
 contrib/completion/git-completion.bash |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 31f714d..d877a23 100755

This seems to be based on 'maint', which has 31f714d, but I see two hits
with "git grep 'COMPREPLY.*compgen' contrib/completion" there, so I am not
sure if that is where you wanted it to apply.

The last place that is not the __gitcomp* functions, of course.

quoted

I see this was not addressed to me (neither was the other zsh one), so I
take it that the patch is still for discussion, at least for the purpose
of today's integration round.  Ping me when it is ready for either 'pu' or
'next'.

I'd say at least one person should say LGTM before asking you to integrate it.

Yeah, it's good to go.


Best,
Gábor