Re: [PATCH] gitweb-lib.sh: Set up PATH to use perl from /usr/bin
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:53:42
Possibly related (same subject, not in this thread)
- 2016-06-15 · [PATCH] gitweb-lib.sh: Set up PATH to use perl from /usr/bin · Torsten Bögershausen <hidden>
- 2016-06-15 · Re: [PATCH] gitweb-lib.sh: Set up PATH to use perl from /usr/bin · Zbigniew Jędrzejewski-Szmek <hidden>
- 2016-06-15 · Re: [PATCH] gitweb-lib.sh: Set up PATH to use perl from /usr/bin · Jeff King <hidden>
- 2016-06-15 · Re: [PATCH] gitweb-lib.sh: Set up PATH to use perl from /usr/bin · Junio C Hamano <hidden>
- 2016-06-15 · Re: [PATCH] gitweb-lib.sh: Set up PATH to use perl from /usr/bin · Zbigniew Jędrzejewski-Szmek <hidden>
Torsten Bögershausen [off-list ref] writes:
quoted hunk
When there are different version of perl installed on the machine, the $PATH may point out a different version of perl than /usr/bin. One example is to have /opt/local/bin/perl before /usr/bin/perl. ...diff --git a/t/gitweb-lib.sh b/t/gitweb-lib.sh index 21d11d6..a016142 100644 --- a/t/gitweb-lib.sh +++ b/t/gitweb-lib.sh@@ -113,4 +113,7 @@ perl -MCGI -MCGI::Util -MCGI::Carp -e 0 >/dev/null 2>&1 || { test_done } +PATH=/usr/bin/:$PATH +export PATH + gitweb_init
This is wrong. What makes you think /usr/bin always has saner version of tools than those in the directories that the user explicitly listed earlier on her $PATH? If anything it should be honoring $PERL_PATH that is set in the Makefile.