On Tue, May 01, 2012 at 06:23:37PM +0200, Zbigniew Jędrzejewski-Szmek wrote:

On 05/01/2012 01:23 PM, Torsten Bögershausen wrote:

quoted

When there are different version of perl installed on the machine,
the $PATH may point out a different version of perl than /usr/bin.
One example is to have /opt/local/bin/perl before /usr/bin/perl.

Sanitize the PATH by adding /usr/bin at the beginning

Hm, I see that most scripts have #!/usr/bin/perl, and only two have
#!env perl [1]. So in general we usally rely on using perl in /usr/bin.

The Makefile substitutes $PERL_PATH on the #!-line of each perl script
during its "build" step (which is really just copying the file to its
final name and running "chmod +x").

So even though the source files say /usr/bin/perl, we are not relying on
that. If you look at the Makefile rule carefully, you will see that even
"#!/usr/bin/env perl" gets replaced, too. Those scripts should probably
be updated, since the mention of env is simply confusing.

But your patch affects other stuff than perl, and unconditionally
changing PATH set by the user is not nice, as it affect programs called
recursively. Wouldn't simply replacing all calls to bare perl in
t/gitweb-lib.sh with invocations of /usr/bin/perl be better?

Yes, although they should use $PERL_PATH rather than hardcoding
/usr/bin.

-Peff