Thread (6 messages) 6 messages, 3 authors, 2016-06-15

Re: [PATCH v2] completion: add new git_complete helper

From: Felipe Contreras <hidden>
Date: 2016-06-15 22:53:36

On Mon, Apr 16, 2012 at 12:37 AM, Jonathan Nieder [off-list ref] wrote:
Felipe Contreras wrote:
quoted
This simplifies the completions, and makes it easier to define aliases:

 git_complete gf git_fetch
Sounds neat.  Unfortunately users could already be using a function
with some other purpose named git_complete in their .profile and this
would override it.  The completion script has so far stuck to a
limited namespace:

       _git_*  (completion functions)
       __git_* (everything else, including public interfaces like __git_ps1)

A name like __git_complete should work, presumably.
Perhaps it's time to avoid the __ prefix for public interfaces;
otherwise how would people know they are public?

-- 
Felipe Contreras
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help