Thread (8 messages) flat view 8 messages, 2 authors, 2016-06-15

Re: [PATCH v3 0/5] completion: trivial cleanups and fixes

From: Jonathan Nieder <hidden>
Date: 2016-06-15 22:53:35

Felipe Contreras wrote:
Just a few simpliciations, improvements, and add some missing options.
I generally like this.  Quick comments:
Felipe Contreras (3):
  completion: simplify __gitcomp_1
Thomas and Gábor seem to have this one covered, with some improvements
to it under discussion.
  completion: trivial simplification
Improves consistency.  The changelog line isn't precise enough to
remind me which change is being mentioned when reading it in the
shortlog, so I guess I'd prefer something like

	completion: simplify by using $prev variable
  completion: add missing general options
Likewise, a subject line like the following would work better for
me.

	completion: --info-path and --no-replace-objects options for git

Hope that helps,
Jonathan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help