Re: [PATCH v2] tests: add initial bash completion tests

2012/4/13 SZEDER Gábor [off-list ref]:

i.e. to set COMP_WORDS and COMP_CWORD in run_completion() and it
worked.  However, I agree that it feels iffy to mess with a
shell-specific variable, and I'm afraid that this just happened to
work on my system, but it might be broken in previous or future bash
versions.

Yeah, we could explore that possibility later, as
_get_comp_words_by_ref is part of the completion, and should be tested
as well, otherwise we might be missing some bugs.

However, I wonder if _get_comp_words_by_ref is needed at all. From
what I can see it has to do with '--foo=bar' and 'foo:bar'
completions, which in fact don't work correctly in zsh (I have patches
for zsh to fix this though), but by modifying the code that checks for
'--*=*' stuff we might be able to get rid of it, or at least the call
to __git_reassemble_comp_words_by_ref. Right?

Cheers.

-- 
Felipe Contreras