Re: [PATCH v2] tests: add initial bash completion tests

2012/4/13 SZEDER Gábor [off-list ref]:

quoted

+test_expect_success 'basic' '
+     run_completion "git \"\"" &&
+     # built-in
+     grep -q "^add \$" out &&
+     # script
+     grep -q "^filter-branch \$" out &&
+     # plumbing
+     ! grep -q "^ls-files \$" out

The && is missing here at the end of the line.

Right.

quoted

+     run_completion "git f" &&
+     ! grep -q -v "^f" out

grep is not a git command, so I'm not sure, but shouldn't these use
'test_must_fail grep' instead of '! grep'?

I'm not sure. Junio has already queued this, maybe you should send a
patch on top of that.

Cheers.

-- 
Felipe Contreras