Thread (25 messages) flat view 25 messages, 4 authors, 2016-06-15

Re: [PATCH v3 0/2] test: tests for the "double > from mailmap" bug

From: Jonathan Nieder <hidden>
Date: 2016-06-15 22:53:04

Felipe Contreras wrote:
The difference of opinion is that I consider the patch already good
enough (adding the comments from Junio).
Ok, I can understand where you're coming from there.

Now I have offered some suggestions for improving some of your
patches.  Applying these suggestions would be effortless, since I sent
them in patch form.  What is your response?  You send a point-by-point
rebuttal explaining how each detail of my suggestions is bad, bad,
bad, and then resend the original with comparatively small changes.

Can you see how this might indicate a stronger difference of opinion
than you have mentioned?  And how a reviewer might make the mistake of
thinking his comments were unwelcome after such an experience?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help