Re: [PATCH 2/2] test: check that "git blame -e" uses mailmap correctly

On Tue, Feb 14, 2012 at 10:36 PM, Jonathan Nieder [off-list ref] wrote:

From: Felipe Contreras <redacted>

test: check that "git blame -e" uses mailmap correctly

I wonder what extra information is in that text that is not in my
original "t: mailmap: add 'git blame -e' tests". I guess all tests
'check' something, and the purpose is to make sure things work
'correctly.

Until f026358e ("mailmap: always return a plain mail address from
map_user()", 2012-02-05), git blame -e would add a spurious '>' after
the unchanged email address with brackets it passed to the mailmap
machinery, resulting in lines with a doubled '>' like this:

 620456e6 ([off-list ref]>   2005-04-07 15:20:13 -0700 8) eight

Add a test to make sure it doesn't happen again.  This reuses the test
data for the existing "shortlog -e" test so it

also tests other kinds of mail mapping.

'Also' is a keyword that strongly denotes this patch is doing more
than one logical thing. My patch adds those checks *independently* of
the fix on f026358e, so it's truly logically independent.

Signed-off-by: Felipe Contreras <redacted>

I did not sign this.

-- 
Felipe Contreras